Source/bindings/core/v8/V8MutationCallback.h - Issue 657983002: Fix crash in MutationObserver::canDeliver due to NULL ExecutionContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8MutationCallback.h

Issue 657983002: Fix crash in MutationObserver::canDeliver due to NULL ExecutionContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8MutationCallback.h

diff --git a/Source/bindings/core/v8/V8MutationCallback.h b/Source/bindings/core/v8/V8MutationCallback.h

index bf3d455e14f048c1c3c4b9181db5f8899530d3bb..bd2ffd9aa0eb7daae7d97cd543de68d49ff6e5bc 100644

--- a/Source/bindings/core/v8/V8MutationCallback.h

+++ b/Source/bindings/core/v8/V8MutationCallback.h

@@ -47,6 +47,7 @@ public:

virtual void call(const WillBeHeapVector<RefPtrWillBeMember<MutationRecord> >&, MutationObserver*) override;

virtual ExecutionContext* executionContext() const override { return ContextLifecycleObserver::executionContext(); }

+ virtual bool canInvokeCallback() const override { return ActiveDOMCallback::canInvokeCallback(); }

private:

V8MutationCallback(v8::Handle<v8::Function>, v8::Handle<v8::Object>, ScriptState*);