Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/bindings/core/v8/V8MutationCallback.h

Issue 657983002: Fix crash in MutationObserver::canDeliver due to NULL ExecutionContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 29 matching lines...) Expand all
40 40
41 class V8MutationCallback final : public MutationCallback, public ActiveDOMCallba ck { 41 class V8MutationCallback final : public MutationCallback, public ActiveDOMCallba ck {
42 public: 42 public:
43 static PassOwnPtr<V8MutationCallback> create(v8::Handle<v8::Function> callba ck, v8::Handle<v8::Object> owner, ScriptState* scriptState) 43 static PassOwnPtr<V8MutationCallback> create(v8::Handle<v8::Function> callba ck, v8::Handle<v8::Object> owner, ScriptState* scriptState)
44 { 44 {
45 return adoptPtr(new V8MutationCallback(callback, owner, scriptState)); 45 return adoptPtr(new V8MutationCallback(callback, owner, scriptState));
46 } 46 }
47 47
48 virtual void call(const WillBeHeapVector<RefPtrWillBeMember<MutationRecord> >&, MutationObserver*) override; 48 virtual void call(const WillBeHeapVector<RefPtrWillBeMember<MutationRecord> >&, MutationObserver*) override;
49 virtual ExecutionContext* executionContext() const override { return Context LifecycleObserver::executionContext(); } 49 virtual ExecutionContext* executionContext() const override { return Context LifecycleObserver::executionContext(); }
50 virtual bool canInvokeCallback() const override { return ActiveDOMCallback:: canInvokeCallback(); }
50 51
51 private: 52 private:
52 V8MutationCallback(v8::Handle<v8::Function>, v8::Handle<v8::Object>, ScriptS tate*); 53 V8MutationCallback(v8::Handle<v8::Function>, v8::Handle<v8::Object>, ScriptS tate*);
53 54
54 static void setWeakCallback(const v8::WeakCallbackData<v8::Function, V8Mutat ionCallback>&); 55 static void setWeakCallback(const v8::WeakCallbackData<v8::Function, V8Mutat ionCallback>&);
55 56
56 ScopedPersistent<v8::Function> m_callback; 57 ScopedPersistent<v8::Function> m_callback;
57 RefPtr<ScriptState> m_scriptState; 58 RefPtr<ScriptState> m_scriptState;
58 }; 59 };
59 60
60 } 61 }
61 62
62 #endif // V8MutationCallback_h 63 #endif // V8MutationCallback_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698