Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 657883003: Disable /analyze for the libexif and yasm projects to hack around internal compiler errors (Closed)

Created:
6 years, 1 month ago by brucedawson
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable /analyze for the libexif and yasm projects to hack around internal compiler errors VC++ hits internal compiler errors on a source file in each of yasm and libexif. This halts the build and prevents full analysis. Therefore this change disables /analyze for those two projects, to increase total coverage. Also fix a typo in libexif's README.chromium BUG=427616 Committed: https://crrev.com/5fb6274c6cd7d57421799bf7ac90991fbcbd7d22 Cr-Commit-Position: refs/heads/master@{#302381}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Wrapping comments at column 80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M third_party/libexif/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libexif/libexif.gyp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/yasm/README.chromium View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/yasm/yasm.gyp View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
brucedawson
6 years, 1 month ago (2014-10-29 22:27:32 UTC) #2
Lei Zhang
libexif lgtm https://codereview.chromium.org/657883003/diff/1/third_party/libexif/libexif.gyp File third_party/libexif/libexif.gyp (right): https://codereview.chromium.org/657883003/diff/1/third_party/libexif/libexif.gyp#newcode94 third_party/libexif/libexif.gyp:94: # As of VS 2013 Update 3, ...
6 years, 1 month ago (2014-10-29 22:33:43 UTC) #3
brucedawson
On 2014/10/29 22:33:43, Lei Zhang wrote: > libexif lgtm > > https://codereview.chromium.org/657883003/diff/1/third_party/libexif/libexif.gyp > File third_party/libexif/libexif.gyp ...
6 years, 1 month ago (2014-10-29 22:37:56 UTC) #4
brucedawson
Alpha -- does this change look good for yasm? It's basically the same change as ...
6 years, 1 month ago (2014-10-31 21:13:02 UTC) #5
Alpha Left Google
LGTM.
6 years, 1 month ago (2014-10-31 21:14:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657883003/20001
6 years, 1 month ago (2014-10-31 21:17:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-01 08:46:47 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5fb6274c6cd7d57421799bf7ac90991fbcbd7d22 Cr-Commit-Position: refs/heads/master@{#302381}
6 years, 1 month ago (2014-11-01 08:47:30 UTC) #10
brucedawson
5 years, 11 months ago (2015-01-09 22:48:47 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698