Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Side by Side Diff: third_party/libexif/libexif.gyp

Issue 657883003: Disable /analyze for the libexif and yasm projects to hack around internal compiler errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libexif/README.chromium ('k') | third_party/yasm/README.chromium » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 ['OS == "linux" and chromeos==0', { 8 ['OS == "linux" and chromeos==0', {
9 'use_system_libexif%': 1, 9 'use_system_libexif%': 1,
10 }, { # OS != "linux" and chromeos==0 10 }, { # OS != "linux" and chromeos==0
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 ], 84 ],
85 'defines': [ 85 'defines': [
86 # This seems like a hack, but this is what WebKit Win does. 86 # This seems like a hack, but this is what WebKit Win does.
87 'snprintf=_snprintf', 87 'snprintf=_snprintf',
88 'inline=__inline', 88 'inline=__inline',
89 ], 89 ],
90 'msvs_disabled_warnings': [ 90 'msvs_disabled_warnings': [
91 4018, # size/unsigned mismatch 91 4018, # size/unsigned mismatch
92 4267, # size_t -> ExifLong truncation on amd64 92 4267, # size_t -> ExifLong truncation on amd64
93 ], 93 ],
94 # As of VS 2013 Update 3, building this project with /analyze hits an
Lei Zhang 2014/10/29 22:33:42 Would you mind limiting comments to 80 chars/line?
95 # internal compiler error on exif-entry.c. This halts the build an d
96 # prevents subsequent analysis. Therefore, /analyze is disabled fo r
97 # this project. See this bug for details:
98 # https://connect.microsoft.com/VisualStudio/feedback/details/1014 689/internal-compiler-error
99 'msvs_settings': {
100 'VCCLCompilerTool': {
101 'AdditionalOptions!': [ '/analyze' ]
102 },
103 },
94 }], 104 }],
95 ], 105 ],
96 }, 106 },
97 ], 107 ],
98 }, { # 'use_system_libexif!=0 108 }, { # 'use_system_libexif!=0
99 'conditions': [ 109 'conditions': [
100 ['sysroot!=""', { 110 ['sysroot!=""', {
101 'variables': { 111 'variables': {
102 'pkg-config': '../../build/linux/pkg-config-wrapper "<(sysroot)" "<( target_arch)" "<(system_libdir)"', 112 'pkg-config': '../../build/linux/pkg-config-wrapper "<(sysroot)" "<( target_arch)" "<(system_libdir)"',
103 }, 113 },
(...skipping 13 matching lines...) Expand all
117 ], 127 ],
118 'defines': [ 128 'defines': [
119 'USE_SYSTEM_LIBEXIF', 129 'USE_SYSTEM_LIBEXIF',
120 ], 130 ],
121 }, 131 },
122 } 132 }
123 ], 133 ],
124 }], 134 }],
125 ] 135 ]
126 } 136 }
OLDNEW
« no previous file with comments | « third_party/libexif/README.chromium ('k') | third_party/yasm/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698