Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/yasm/yasm.gyp

Issue 657883003: Disable /analyze for the libexif and yasm projects to hack around internal compiler errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wrapping comments at column 80 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/yasm/README.chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/yasm.gyp
diff --git a/third_party/yasm/yasm.gyp b/third_party/yasm/yasm.gyp
index 78f196676670c052b007b7608c3adfcee0e978a0..0c21b8380557353f1e9581cc85c1194f84ebd0a0 100644
--- a/third_party/yasm/yasm.gyp
+++ b/third_party/yasm/yasm.gyp
@@ -77,6 +77,21 @@
'-Wno-incompatible-pointer-types',
],
},
+ 'conditions': [
+ ['OS=="win"', {
+ # As of VS 2013 Update 3, building this project with /analyze hits an
+ # internal compiler error on elf-x86-amd64.c in release builds with
+ # the amd64_x86 compiler. This halts the build and prevents subsequent
+ # analysis. Therefore, /analyze is disabled for this project. See this
+ # bug for details:
+ # https://connect.microsoft.com/VisualStudio/feedback/details/1014799/internal-compiler-error-when-using-analyze
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions!': [ '/analyze' ]
+ },
+ },
+ }],
+ ],
'sources': [
'source/patched-yasm/frontends/yasm/yasm-options.c',
'source/patched-yasm/frontends/yasm/yasm.c',
« no previous file with comments | « third_party/yasm/README.chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698