[Password Generation] Add accessibility alert when popup is shown in Views

[Password Generation] Add accessibility alert when popup is shown in Views

BUG=363324
TBR=groby@chromium.org

Committed: https://crrev.com/b94b8fd3bccab5e64f3155b3e3eb7fc2a2900a71
Cr-Commit-Position: refs/heads/master@{#300967}

[Garrett Casto, 2014-10-16 22:38:48]

gcasto@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Garrett Casto, 2014-10-16 22:38:49]

I'm not sure if this implementation is exactly correct. Output from Vox when
selecting the signup field on Facebook looks like

[28652:28652:1016/145611:INFO:CONSOLE(1557)] "Speak (C) category=nav "New
password with hint"", source:
chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromeBackgroundScript.js
(1557)
[28652:28652:1016/145611:INFO:CONSOLE(1557)] "  using startCallback", source:
chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromeBackgroundScript.js
(1557)
[28652:28652:1016/145611:INFO:CONSOLE(1557)] "Speak (Q) category=nav "Password
edit text has popup"", source:
chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromeBackgroundScript.js
(1557)
[28652:28652:1016/145611:INFO:CONSOLE(1558)] "  using endCallback", source:
chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromeBackgroundScript.js
(1558)
[28652:28652:1016/145611:INFO:CONSOLE(2062)] "RPC ->
{"table_names":"en-us-comp8.ctb,cvox-common.cti","text":"New password with hint:
pwd edtxt","message_id":"148","command":"Translate"}", source:
chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromeBackgroundScript.js
(2062)

So there is a message that a popup is on the text field, but I didn't see the
name (or value when I set that) propagated.

[dmazzoni, 2014-10-17 16:23:12]

lgtm

https://codereview.chromium.org/657633004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/657633004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14197: +    <message
name="IDS_PASSWORD_GENERATION_ACCESSIBILITY_NAME" desc="The accessibility name
of the popup asking users if they would like Chrome to generate a password for
them.">
Optional: we usually use ACCESSIBLE_NAME over ACCESSIBILITY_NAME. Maybe
ACCESSIBLE_TITLE would be even more clear?

https://codereview.chromium.org/657633004/diff/1/chrome/browser/ui/autofill/p...
File chrome/browser/ui/autofill/password_generation_popup_controller.h (right):

https://codereview.chromium.org/657633004/diff/1/chrome/browser/ui/autofill/p...
chrome/browser/ui/autofill/password_generation_popup_controller.h:45: virtual
base::string16 AccessibilityName() = 0;
AccessibleName

[dmazzoni, 2014-10-17 16:24:47]

> So there is a message that a popup is on the text field, but I didn't see the
> name (or value when I set that) propagated.

I'd be surprised if it doesn't work if it's a standard text field. Does
ChromeVox announce anything when you type in the field?

Happy to help test - could you provide instructions for how to pop up this
dialog once this lands?

[Garrett Casto, 2014-10-17 19:04:14]

The easiest way to trigger this feature is to add specify
"--local-heuristics-only-for-password-generation" and then focus a password
field on a form that has at least 3 text/password fields (Facebook/Twitter
signup both work).

Note that typing in the password field doesn't give any output regarding the
popup.

https://codereview.chromium.org/657633004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/657633004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14197: +    <message
name="IDS_PASSWORD_GENERATION_ACCESSIBILITY_NAME" desc="The accessibility name
of the popup asking users if they would like Chrome to generate a password for
them.">
On 2014/10/17 16:23:12, dmazzoni wrote:
> Optional: we usually use ACCESSIBLE_NAME over ACCESSIBILITY_NAME. Maybe
> ACCESSIBLE_TITLE would be even more clear?

Done.

https://codereview.chromium.org/657633004/diff/1/chrome/browser/ui/autofill/p...
File chrome/browser/ui/autofill/password_generation_popup_controller.h (right):

https://codereview.chromium.org/657633004/diff/1/chrome/browser/ui/autofill/p...
chrome/browser/ui/autofill/password_generation_popup_controller.h:45: virtual
base::string16 AccessibilityName() = 0;
On 2014/10/17 16:23:12, dmazzoni wrote:
> AccessibleName

Done.

[Garrett Casto, 2014-10-23 18:26:31]

gcasto@chromium.org changed reviewers:
+ estade@chromium.org

[Garrett Casto, 2014-10-23 18:26:32]

Evan, mind taking a look?

[Evan Stade, 2014-10-23 18:35:50]

lgtm

[Garrett Casto, 2014-10-23 18:36:37]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-10-23 18:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657633004/20001

[commit-bot: I haz the power, 2014-10-23 18:43:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 18:43:21]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/72675)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/77611)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Garrett Casto, 2014-10-23 18:49:09]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-10-23 18:50:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657633004/40001

[commit-bot: I haz the power, 2014-10-23 19:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 19:37:34]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Garrett Casto, 2014-10-23 21:20:33]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-10-23 21:22:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657633004/60001

[commit-bot: I haz the power, 2014-10-23 23:02:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-23 23:02:45]

Patchset 4 (id:??) landed as
https://crrev.com/b94b8fd3bccab5e64f3155b3e3eb7fc2a2900a71
Cr-Commit-Position: refs/heads/master@{#300967}