chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm - Issue 657633004: [Password Generation] Add accessibility alert when popup is shown in Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm

Issue 657633004: [Password Generation] Add accessibility alert when popup is shown in Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc ('k') | chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm

index 2123185c9a75a2cbe1bc6fdea72b38be1873a9f0..7e9633b8ca7d36e0790e856b1db991cec13b1ce9 100644

--- a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm

@@ -42,6 +42,10 @@ class MockPasswordGenerationPopupController

return base::ASCIIToUTF16("Suggested by Chrome");

}

+ virtual base::string16 AccessibleName() override {

+ return base::ASCIIToUTF16("Password Suggestion");

+ }

virtual const base::string16& HelpText() override { return help_text_; }

virtual const gfx::Range& HelpTextLinkRange() override { return link_range_; }