chrome/app/generated_resources.grd - Issue 657633004: [Password Generation] Add accessibility alert when popup is shown in Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 657633004: [Password Generation] Add accessibility alert when popup is shown in Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/password_generation_popup_controller.h » ('j') | chrome/browser/ui/autofill/password_generation_popup_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 52442f6344bbd0a25278d116ae577c03577c039e..139e8ad6a9dd5d5d77418525478e0ad8bb69852e 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -14194,12 +14194,9 @@ Do you accept?

</message>

- <message name="IDS_PASSWORD_GENERATION_BUBBLE_TITLE" desc="The title of the bubble asking users if they would like Chrome to generate a password for them on an account creation page.">

+ <message name="IDS_PASSWORD_GENERATION_ACCESSIBILITY_NAME" desc="The accessibility name of the popup asking users if they would like Chrome to generate a password for them.">

dmazzoni 2014/10/17 16:23:12 Optional: we usually use ACCESSIBLE_NAME over ACCE

Garrett Casto 2014/10/17 19:04:14 Done.

Password Suggestion

</message>

- <message name="IDS_PASSWORD_GENERATION_BUTTON_TEXT" desc="The text on the button that users click to accept the generated password">

- Try it

- </message>