Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657393003: Make ApplicationImpl::args() be a std::vector<std::string> (Closed)

Created:
6 years, 2 months ago by DaveMoore
Modified:
6 years, 2 months ago
Reviewers:
sky, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Make ApplicationImpl::args() be a std::vector<std::string> BUG= Committed: https://crrev.com/7cbf7ae277ab297529d5ae4b5f3f61cc37bc77ea Cr-Commit-Position: refs/heads/master@{#300033}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M mojo/application_manager/application_manager_unittest.cc View 1 chunk +1 line, -3 lines 1 comment Download
M mojo/examples/apptest/example_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wget/wget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/application_impl.h View 2 chunks +2 lines, -2 lines 1 comment Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/main.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
DaveMoore
6 years, 2 months ago (2014-10-16 22:38:51 UTC) #2
sky
LGTM
6 years, 2 months ago (2014-10-16 22:41:32 UTC) #3
viettrungluu
https://codereview.chromium.org/657393003/diff/1/mojo/application_manager/application_manager_unittest.cc File mojo/application_manager/application_manager_unittest.cc (right): https://codereview.chromium.org/657393003/diff/1/mojo/application_manager/application_manager_unittest.cc#newcode111 mojo/application_manager/application_manager_unittest.cc:111: const std::vector<std::string>& GetArgs() { return test_app_->args(); } This method ...
6 years, 2 months ago (2014-10-16 22:47:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657393003/1
6 years, 2 months ago (2014-10-16 23:17:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 01:19:09 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 01:19:40 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7cbf7ae277ab297529d5ae4b5f3f61cc37bc77ea
Cr-Commit-Position: refs/heads/master@{#300033}

Powered by Google App Engine
This is Rietveld 408576698