Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: mojo/public/cpp/application/application_impl.h

Issue 657393003: Make ApplicationImpl::args() be a std::vector<std::string> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/application/application_impl.h
diff --git a/mojo/public/cpp/application/application_impl.h b/mojo/public/cpp/application/application_impl.h
index b647427b1bdf18ab319e29ca36d9cbbced6ea76c..bc3660306a205e87feca22daabe5ea615e07ae33 100644
--- a/mojo/public/cpp/application/application_impl.h
+++ b/mojo/public/cpp/application/application_impl.h
@@ -60,7 +60,7 @@ class ApplicationImpl : public InterfaceImpl<Application> {
Shell* shell() const { return shell_.get(); }
// Returns any initial configuration arguments, passed by the Shell.
- const Array<String>& args() { return args_; }
+ const std::vector<std::string>& args() { return args_; }
viettrungluu 2014/10/16 22:47:19 This method should be const.
// Establishes a new connection to an application. Caller does not own.
ApplicationConnection* ConnectToApplication(const String& application_url);
@@ -102,7 +102,7 @@ class ApplicationImpl : public InterfaceImpl<Application> {
ApplicationDelegate* delegate_;
ShellPtr shell_;
ShellPtrWatcher* shell_watch_;
- Array<String> args_;
+ std::vector<std::string> args_;
MOJO_DISALLOW_COPY_AND_ASSIGN(ApplicationImpl);
};

Powered by Google App Engine
This is Rietveld 408576698