mojo/application_manager/application_manager_unittest.cc - Issue 657393003: Make ApplicationImpl::args() be a std::vector<std::string>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application_manager/application_manager_unittest.cc

Issue 657393003: Make ApplicationImpl::args() be a std::vector<std::string> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/application_manager/application_manager_unittest.cc

diff --git a/mojo/application_manager/application_manager_unittest.cc b/mojo/application_manager/application_manager_unittest.cc

index 5763265f37939aace9b3480fab502b05cc45a8a0..a5d750ec5df4ef6c78acea2893e935c1c7a7756d 100644

--- a/mojo/application_manager/application_manager_unittest.cc

+++ b/mojo/application_manager/application_manager_unittest.cc

@@ -108,9 +108,7 @@ class TestApplicationLoader : public ApplicationLoader,

void set_context(TestContext* context) { context_ = context; }

int num_loads() const { return num_loads_; }

- std::vector<std::string> GetArgs() {

- return test_app_->args().To<std::vector<std::string> >();

- }

+ const std::vector<std::string>& GetArgs() { return test_app_->args(); }

viettrungluu 2014/10/16 22:47:19 This method should be const.

private:

// ApplicationLoader implementation.

« no previous file with comments | « no previous file | mojo/examples/apptest/example_apptest.cc » ('j') | mojo/public/cpp/application/application_impl.h » ('J')