chrome/browser/safe_browsing/local_two_phase_testserver.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/local_two_phase_testserver.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/local_safebrowsing_test_server.h ('k') | chrome/browser/safe_browsing/malware_details.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/local_two_phase_testserver.h

diff --git a/chrome/browser/safe_browsing/local_two_phase_testserver.h b/chrome/browser/safe_browsing/local_two_phase_testserver.h

index 1b6bffd303155845fb0f1fe695d207f5b92e8117..1614521e9624fac31ae4da86d08363cf486d13ee 100644

--- a/chrome/browser/safe_browsing/local_two_phase_testserver.h

+++ b/chrome/browser/safe_browsing/local_two_phase_testserver.h

@@ -17,11 +17,10 @@ class LocalTwoPhaseTestServer : public net::LocalTestServer {

// Initialize a two phase protocol test server.

LocalTwoPhaseTestServer();

- virtual ~LocalTwoPhaseTestServer();

+ ~LocalTwoPhaseTestServer() override;

// Returns the path to two_phase_testserver.py.

- virtual bool GetTestServerPath(

- base::FilePath* testserver_path) const override;

+ bool GetTestServerPath(base::FilePath* testserver_path) const override;

private:

DISALLOW_COPY_AND_ASSIGN(LocalTwoPhaseTestServer);

« no previous file with comments | « chrome/browser/safe_browsing/local_safebrowsing_test_server.h ('k') | chrome/browser/safe_browsing/malware_details.h » ('j') | no next file with comments »