chrome/browser/safe_browsing/malware_details.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/malware_details.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/malware_details.h

diff --git a/chrome/browser/safe_browsing/malware_details.h b/chrome/browser/safe_browsing/malware_details.h

index 059588b31e05ca584046908cbc0d68a67d6a110f..51dff4bbc077968b3131f61f965d7a4f29f3a23c 100644

--- a/chrome/browser/safe_browsing/malware_details.h

+++ b/chrome/browser/safe_browsing/malware_details.h

@@ -70,7 +70,7 @@ class MalwareDetails : public base::RefCountedThreadSafe<MalwareDetails>,

void OnRedirectionCollectionReady();

// content::WebContentsObserver implementation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

protected:

friend class MalwareDetailsFactoryImpl;

@@ -79,7 +79,7 @@ class MalwareDetails : public base::RefCountedThreadSafe<MalwareDetails>,

content::WebContents* web_contents,

const UnsafeResource& resource);

- virtual ~MalwareDetails();

+ ~MalwareDetails() override;

// Called on the IO thread with the DOM details.

virtual void AddDOMDetails(

« no previous file with comments | « chrome/browser/safe_browsing/local_two_phase_testserver.h ('k') | chrome/browser/safe_browsing/malware_details.cc » ('j') | no next file with comments »