chrome/browser/safe_browsing/local_safebrowsing_test_server.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/local_safebrowsing_test_server.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h ('k') | chrome/browser/safe_browsing/local_two_phase_testserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/local_safebrowsing_test_server.h

diff --git a/chrome/browser/safe_browsing/local_safebrowsing_test_server.h b/chrome/browser/safe_browsing/local_safebrowsing_test_server.h

index 1bdc9a9f1112476889e927fded0f2a187b1a31e5..763938506d2e0c53e05bb665cc75b2b7f36b7ff1 100644

--- a/chrome/browser/safe_browsing/local_safebrowsing_test_server.h

+++ b/chrome/browser/safe_browsing/local_safebrowsing_test_server.h

@@ -17,17 +17,16 @@ class LocalSafeBrowsingTestServer : public net::LocalTestServer {

// Initialize a safebrowsing server using the given |data_file|.

explicit LocalSafeBrowsingTestServer(const base::FilePath& data_file);

- virtual ~LocalSafeBrowsingTestServer();

+ ~LocalSafeBrowsingTestServer() override;

- virtual bool SetPythonPath() const override;

+ bool SetPythonPath() const override;

// Returns the path to safe_browsing_testserver.py.

- virtual bool GetTestServerPath(

- base::FilePath* testserver_path) const override;

+ bool GetTestServerPath(base::FilePath* testserver_path) const override;

protected:

// Adds the --data-file switch. Returns true on success.

- virtual bool GenerateAdditionalArguments(

+ bool GenerateAdditionalArguments(

base::DictionaryValue* arguments) const override;

private: