chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.h ('k') | chrome/browser/safe_browsing/local_safebrowsing_test_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

index 6addfaef9f3a5ea5e1d6bb0e90ea0a921de54a11..c013993ab1a2a7a0af463ae0000fe802e3825a6c 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

@@ -19,16 +19,16 @@ class PreferenceValidationDelegate

public:

explicit PreferenceValidationDelegate(

const AddIncidentCallback& add_incident);

- virtual ~PreferenceValidationDelegate();

+ ~PreferenceValidationDelegate() override;

private:

// TrackedPreferenceValidationDelegate methods.

- virtual void OnAtomicPreferenceValidation(

+ void OnAtomicPreferenceValidation(

const std::string& pref_path,

const base::Value* value,

PrefHashStoreTransaction::ValueState value_state,

TrackedPreferenceHelper::ResetAction reset_action) override;

- virtual void OnSplitPreferenceValidation(

+ void OnSplitPreferenceValidation(

const std::string& pref_path,

const base::DictionaryValue* dict_value,

const std::vector<std::string>& invalid_keys,