chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h ('k') | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

index 10fb114e3f2b56042222a6a2d68b49580819cc21..9434e66e72ccde8aad310b31e890e215347459b1 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

@@ -71,7 +71,7 @@ class IncidentReportingService : public content::NotificationObserver {

// All incident collection, data collection, and uploads in progress are

// dropped at destruction.

- virtual ~IncidentReportingService();

+ ~IncidentReportingService() override;

// Returns a callback by which external components can add an incident to the

// service on behalf of |profile|. The callback may outlive the service, but

@@ -233,9 +233,9 @@ class IncidentReportingService : public content::NotificationObserver {

scoped_ptr<ClientIncidentResponse> response);

// content::NotificationObserver methods.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

base::ThreadChecker thread_checker_;