Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
index 9e469c177b65a220f908a55704245a5b376a443c..ae6c3cebd310ef7b1a208edf5a8288f11e022359 100644
--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
@@ -68,25 +68,25 @@ class IncidentReportingServiceTest : public testing::Test {
test_instance_.Get().Set(this);
}
- virtual ~TestIncidentReportingService() { test_instance_.Get().Set(NULL); }
+ ~TestIncidentReportingService() override { test_instance_.Get().Set(NULL); }
bool IsProcessingReport() const {
return IncidentReportingService::IsProcessingReport();
}
protected:
- virtual void OnProfileAdded(Profile* profile) override {
+ void OnProfileAdded(Profile* profile) override {
pre_profile_add_callback_.Run(profile);
safe_browsing::IncidentReportingService::OnProfileAdded(profile);
}
- virtual scoped_ptr<safe_browsing::LastDownloadFinder> CreateDownloadFinder(
+ scoped_ptr<safe_browsing::LastDownloadFinder> CreateDownloadFinder(
const safe_browsing::LastDownloadFinder::LastDownloadCallback& callback)
override {
return create_download_finder_callback_.Run(callback);
}
- virtual scoped_ptr<safe_browsing::IncidentReportUploader> StartReportUpload(
+ scoped_ptr<safe_browsing::IncidentReportUploader> StartReportUpload(
const safe_browsing::IncidentReportUploader::OnResultCallback& callback,
const scoped_refptr<net::URLRequestContextGetter>&
request_context_getter,
@@ -315,7 +315,7 @@ class IncidentReportingServiceTest : public testing::Test {
FROM_HERE,
base::Bind(&FakeUploader::FinishUpload, base::Unretained(this)));
}
- virtual ~FakeUploader() { on_deleted_.Run(); }
+ ~FakeUploader() override { on_deleted_.Run(); }
private:
void FinishUpload() {
@@ -346,7 +346,7 @@ class IncidentReportingServiceTest : public testing::Test {
new FakeDownloadFinder(on_deleted));
}
- virtual ~FakeDownloadFinder() { on_deleted_.Run(); }
+ ~FakeDownloadFinder() override { on_deleted_.Run(); }
private:
explicit FakeDownloadFinder(const base::Closure& on_deleted)

Powered by Google App Engine
This is Rietveld 408576698