chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h b/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h

index 83aadd925c3534959ca3504f4899b8500185d600..4c755714b74408b53e89cd3b36a37f367c0d1482 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h

@@ -34,7 +34,7 @@ class IncidentReportUploaderImpl : public IncidentReportUploader,

// The id associated with the URLFetcher, for use by tests.

static const int kTestUrlFetcherId;

- virtual ~IncidentReportUploaderImpl();

+ ~IncidentReportUploaderImpl() override;

// Uploads a report with a caller-provided URL context. |callback| will be run

// when the upload is complete. Returns NULL if |report| cannot be serialized

@@ -54,7 +54,7 @@ class IncidentReportUploaderImpl : public IncidentReportUploader,

static GURL GetIncidentReportUrl();

// net::URLFetcherDelegate methods.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// The underlying URL fetcher. The instance is alive from construction through

// OnURLFetchComplete.