Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc
index 9aed0ae9f8e86c9fca16856e0f144d78327e58f4..93324cf30188e5bac858c5dba027b76f1de50c2b 100644
--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc
+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc
@@ -90,14 +90,14 @@ class FakeSafeBrowsingService : public SafeBrowsingService {
}
protected:
- virtual ~FakeSafeBrowsingService() { }
+ ~FakeSafeBrowsingService() override {}
- virtual SafeBrowsingDatabaseManager* CreateDatabaseManager() override {
+ SafeBrowsingDatabaseManager* CreateDatabaseManager() override {
mock_database_manager_ = new MockSafeBrowsingDatabaseManager(this);
return mock_database_manager_;
}
- virtual void RegisterAllDelayedAnalysis() override { }
+ void RegisterAllDelayedAnalysis() override {}
private:
MockSafeBrowsingDatabaseManager* mock_database_manager_;
@@ -131,12 +131,12 @@ class TestURLFetcherWatcher : public net::TestURLFetcherDelegateForTests {
}
// TestURLFetcherDelegateForTests impl:
- virtual void OnRequestStart(int fetcher_id) override {
+ void OnRequestStart(int fetcher_id) override {
fetcher_id_ = fetcher_id;
run_loop_.Quit();
}
- virtual void OnChunkUpload(int fetcher_id) override {}
- virtual void OnRequestEnd(int fetcher_id) override {}
+ void OnChunkUpload(int fetcher_id) override {}
+ void OnRequestEnd(int fetcher_id) override {}
int WaitForRequest() {
run_loop_.Run();

Powered by Google App Engine
This is Rietveld 408576698