chrome/browser/safe_browsing/download_feedback.cc - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/database_manager.h ('k') | chrome/browser/safe_browsing/download_feedback_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback.cc

diff --git a/chrome/browser/safe_browsing/download_feedback.cc b/chrome/browser/safe_browsing/download_feedback.cc

index dfa248b1f86d97f3fe7000961adc7a38b715571c..27f4008ceb85f532ffd65bfc1b6bf5dc8e1d8820 100644

--- a/chrome/browser/safe_browsing/download_feedback.cc

+++ b/chrome/browser/safe_browsing/download_feedback.cc

@@ -38,15 +38,15 @@ class DownloadFeedbackImpl : public DownloadFeedback {

const base::FilePath& file_path,

const std::string& ping_request,

const std::string& ping_response);

- virtual ~DownloadFeedbackImpl();

+ ~DownloadFeedbackImpl() override;

- virtual void Start(const base::Closure& finish_callback) override;

+ void Start(const base::Closure& finish_callback) override;

- virtual const std::string& GetPingRequestForTesting() const override {

+ const std::string& GetPingRequestForTesting() const override {

return ping_request_;

}

- virtual const std::string& GetPingResponseForTesting() const override {

+ const std::string& GetPingResponseForTesting() const override {

return ping_response_;

}