Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/safe_browsing/database_manager.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/database_manager.h
diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h
index 824800a0e2fa6048f7c773f9ff2c7fc6c5f514a1..e001a35e0705516df9fa53fe56b52d0dfecbc81e 100644
--- a/chrome/browser/safe_browsing/database_manager.h
+++ b/chrome/browser/safe_browsing/database_manager.h
@@ -205,7 +205,7 @@ class SafeBrowsingDatabaseManager
void StopOnIOThread(bool shutdown);
protected:
- virtual ~SafeBrowsingDatabaseManager();
+ ~SafeBrowsingDatabaseManager() override;
// protected for tests.
void NotifyDatabaseUpdateFinished(bool update_succeeded);
@@ -341,15 +341,15 @@ class SafeBrowsingDatabaseManager
const base::Closure& task);
// SafeBrowsingProtocolManageDelegate override
- virtual void ResetDatabase() override;
- virtual void UpdateStarted() override;
- virtual void UpdateFinished(bool success) override;
- virtual void GetChunks(GetChunksCallback callback) override;
- virtual void AddChunks(const std::string& list,
- scoped_ptr<ScopedVector<SBChunkData> > chunks,
- AddChunksCallback callback) override;
- virtual void DeleteChunks(
- scoped_ptr<std::vector<SBChunkDelete> > chunk_deletes) override;
+ void ResetDatabase() override;
+ void UpdateStarted() override;
+ void UpdateFinished(bool success) override;
+ void GetChunks(GetChunksCallback callback) override;
+ void AddChunks(const std::string& list,
+ scoped_ptr<ScopedVector<SBChunkData>> chunks,
+ AddChunksCallback callback) override;
+ void DeleteChunks(
+ scoped_ptr<std::vector<SBChunkDelete>> chunk_deletes) override;
scoped_refptr<SafeBrowsingService> sb_service_;
« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.h ('k') | chrome/browser/safe_browsing/download_feedback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698