Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_feedback_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc
index e545b8d12ef2d3d73403ba31c5a53fec5225d14f..450524f3cd08de71872a06e81daa99471f434260 100644
--- a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc
+++ b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc
@@ -40,20 +40,18 @@ class FakeDownloadFeedback : public DownloadFeedback {
start_called_(false) {
}
- virtual ~FakeDownloadFeedback() {
- deletion_callback_.Run();
- }
+ ~FakeDownloadFeedback() override { deletion_callback_.Run(); }
- virtual void Start(const base::Closure& finish_callback) override {
+ void Start(const base::Closure& finish_callback) override {
start_called_ = true;
finish_callback_ = finish_callback;
}
- virtual const std::string& GetPingRequestForTesting() const override {
+ const std::string& GetPingRequestForTesting() const override {
return ping_request_;
}
- virtual const std::string& GetPingResponseForTesting() const override {
+ const std::string& GetPingResponseForTesting() const override {
return ping_response_;
}
@@ -79,9 +77,9 @@ class FakeDownloadFeedback : public DownloadFeedback {
class FakeDownloadFeedbackFactory : public DownloadFeedbackFactory {
public:
- virtual ~FakeDownloadFeedbackFactory() {}
+ ~FakeDownloadFeedbackFactory() override {}
- virtual DownloadFeedback* CreateDownloadFeedback(
+ DownloadFeedback* CreateDownloadFeedback(
net::URLRequestContextGetter* request_context_getter,
base::TaskRunner* file_task_runner,
const base::FilePath& file_path,
« no previous file with comments | « chrome/browser/safe_browsing/download_feedback.cc ('k') | chrome/browser/safe_browsing/download_feedback_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698