Issue 656853002: Use GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure of FP creation in SkIma…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656853002: Use GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure of FP creation in SkIma… (Closed)

Created:
6 years, 2 months ago by bsalomon

Modified:
6 years, 2 months ago

Reviewers:
egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Use GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure of FP creation in SkImageFilter BUG=skia:2922 Committed: https://skia.googlesource.com/skia/+/b501ecd0d7aa1c49c8c7f407ac6d51f5dc93122f

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	src/core/SkImageFilter.cpp	View		1 chunk	+11 lines, -11 lines	0 comments	Download
	M	src/gpu/gl/GrGpuGL.cpp	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656853002/1

6 years, 2 months ago (2014-10-14 15:30:18 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-14 15:41:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as b501ecd0d7aa1c49c8c7f407ac6d51f5dc93122f