Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 656643004: Let setShouldDoFullPaintInvalidation accept reason (Closed)

Created:
6 years, 2 months ago by Xianzhu
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Let setShouldDoFullPaintInvalidation accept reason Combines setShouldDoFullPaintInvalidationWithReason() into setShouldDoFullPaintInvalidation(). This is preparation to allow more paint invalidation reasons. For now allow default value. In the future we may force every setShouldDoFullPaintInvalidation to have a reason, when we can remove the default value. BUG=410465 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
6 years, 2 months ago (2014-10-14 18:34:08 UTC) #2
pdr.
On 2014/10/14 at 18:34:08, wangxianzhu wrote: > LGTM
6 years, 2 months ago (2014-10-14 19:14:04 UTC) #3
pdr.
+cc kouhei just fyi
6 years, 2 months ago (2014-10-14 19:14:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656643004/1
6 years, 2 months ago (2014-10-14 19:15:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 22:22:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183700

Powered by Google App Engine
This is Rietveld 408576698