Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: Source/core/rendering/RenderObjectChildList.cpp

Issue 656643004: Let setShouldDoFullPaintInvalidation accept reason (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 3 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 } 155 }
156 156
157 if (!owner->documentBeingDestroyed() && notifyRenderer) 157 if (!owner->documentBeingDestroyed() && notifyRenderer)
158 newChild->insertedIntoTree(); 158 newChild->insertedIntoTree();
159 159
160 if (!owner->documentBeingDestroyed()) { 160 if (!owner->documentBeingDestroyed()) {
161 RenderCounter::rendererSubtreeAttached(newChild); 161 RenderCounter::rendererSubtreeAttached(newChild);
162 } 162 }
163 163
164 newChild->setNeedsLayoutAndPrefWidthsRecalc(); 164 newChild->setNeedsLayoutAndPrefWidthsRecalc();
165 newChild->setShouldDoFullPaintInvalidationWithReason(PaintInvalidationRender erInsertion); 165 newChild->setShouldDoFullPaintInvalidation(PaintInvalidationRendererInsertio n);
166 if (!owner->normalChildNeedsLayout()) 166 if (!owner->normalChildNeedsLayout())
167 owner->setChildNeedsLayout(); // We may supply the static position for a n absolute positioned child. 167 owner->setChildNeedsLayout(); // We may supply the static position for a n absolute positioned child.
168 168
169 if (AXObjectCache* cache = owner->document().axObjectCache()) 169 if (AXObjectCache* cache = owner->document().axObjectCache())
170 cache->childrenChanged(owner); 170 cache->childrenChanged(owner);
171 } 171 }
172 172
173 void RenderObjectChildList::invalidatePaintOnRemoval(const RenderObject& oldChil d) 173 void RenderObjectChildList::invalidatePaintOnRemoval(const RenderObject& oldChil d)
174 { 174 {
175 if (!oldChild.isRooted()) 175 if (!oldChild.isRooted())
176 return; 176 return;
177 if (oldChild.isBody()) { 177 if (oldChild.isBody()) {
178 oldChild.view()->setShouldDoFullPaintInvalidation(); 178 oldChild.view()->setShouldDoFullPaintInvalidation();
179 return; 179 return;
180 } 180 }
181 if (oldChild.isText()) { 181 if (oldChild.isText()) {
182 oldChild.parent()->setShouldDoFullPaintInvalidation(); 182 oldChild.parent()->setShouldDoFullPaintInvalidation();
183 return; 183 return;
184 } 184 }
185 DisableCompositingQueryAsserts disabler; 185 DisableCompositingQueryAsserts disabler;
186 oldChild.invalidatePaintUsingContainer(oldChild.containerForPaintInvalidatio n(), oldChild.previousPaintInvalidationRect(), PaintInvalidationRendererRemoval) ; 186 oldChild.invalidatePaintUsingContainer(oldChild.containerForPaintInvalidatio n(), oldChild.previousPaintInvalidationRect(), PaintInvalidationRendererRemoval) ;
187 } 187 }
188 188
189 } // namespace blink 189 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698