Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 656293002: Fix MSAA+IA2 & AX for <header> tag and banner role (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
*dmazzoni, *jam, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix MSAA+IA2 & AX for <header> tag and banner role According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html and http://www.w3.org/WAI/PF/aria-implementation/ It should be exposed as below when header is not contained by article or section elements MSAA+IA2 Role: IA2_ROLE_HEADER Object attributes: xml-roles:banner AX AXRole: AXGroup AXSubrole: AXLandmarkBanner AXRoleDescription: "banner" BUG=282262 Committed: https://crrev.com/91345e19938b191ee3afc14cf6656b9ba8edd330 Cr-Commit-Position: refs/heads/master@{#300411}

Patch Set 1 #

Patch Set 2 : Updating expectations for mac and android #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -3 lines) Patch
M content/app/strings/content_strings.grd View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-banner.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-banner-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-banner-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-banner-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/header.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/header-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/header-expected-mac.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/header-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/landmark-expected-win.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
shreeramk
Please review. Thanks :)
6 years, 2 months ago (2014-10-17 08:32:44 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/656293002/diff/40001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/656293002/diff/40001/content/app/strings/content_strings.grd#newcode338 content/app/strings/content_strings.grd:338: <message name="IDS_AX_ROLE_BANNER" desc="accessibility role description for header"> same ...
6 years, 2 months ago (2014-10-17 17:01:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656293002/60001
6 years, 2 months ago (2014-10-20 16:07:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18655)
6 years, 2 months ago (2014-10-20 16:14:43 UTC) #8
shreeramk
On 2014/10/20 16:14:43, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-20 17:50:01 UTC) #11
jam
lgtm
6 years, 2 months ago (2014-10-20 20:10:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656293002/60001
6 years, 2 months ago (2014-10-21 03:25:21 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-21 03:29:28 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 03:32:45 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/91345e19938b191ee3afc14cf6656b9ba8edd330
Cr-Commit-Position: refs/heads/master@{#300411}

Powered by Google App Engine
This is Rietveld 408576698