content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 656293002: Fix MSAA+IA2 & AX for <header> tag and banner role

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 656293002: Fix MSAA+IA2 & AX for <header> tag and banner role (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 75c3ff1fe831d4e596d28318035c7bd7dabb647b..1172e34903dcb0e116c6db7206c6a0fe6b3caced 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -575,6 +575,10 @@ NSDictionary* attributeToMethodNameMap = nil;

}

switch([self internalRole]) {

+ case ui::AX_ROLE_BANNER:

+ return base::SysUTF16ToNSString(content_client->GetLocalizedString(

+ IDS_AX_ROLE_BANNER));

+ break;

case ui::AX_ROLE_FOOTER:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

IDS_AX_ROLE_FOOTER));