Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 656293002: Fix MSAA+IA2 & AX for <header> tag and banner role (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <execinfo.h> 5 #include <execinfo.h>
6 6
7 #import "content/browser/accessibility/browser_accessibility_cocoa.h" 7 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 if ((internalRole != ui::AX_ROLE_GROUP && 568 if ((internalRole != ui::AX_ROLE_GROUP &&
569 internalRole != ui::AX_ROLE_LIST_ITEM) || 569 internalRole != ui::AX_ROLE_LIST_ITEM) ||
570 internalRole == ui::AX_ROLE_TAB) { 570 internalRole == ui::AX_ROLE_TAB) {
571 // TODO(dtseng): This is not localized; see crbug/84814. 571 // TODO(dtseng): This is not localized; see crbug/84814.
572 return base::SysUTF8ToNSString(role); 572 return base::SysUTF8ToNSString(role);
573 } 573 }
574 } 574 }
575 } 575 }
576 576
577 switch([self internalRole]) { 577 switch([self internalRole]) {
578 case ui::AX_ROLE_BANNER:
579 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
580 IDS_AX_ROLE_BANNER));
581 break;
578 case ui::AX_ROLE_FOOTER: 582 case ui::AX_ROLE_FOOTER:
579 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 583 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
580 IDS_AX_ROLE_FOOTER)); 584 IDS_AX_ROLE_FOOTER));
581 case ui::AX_ROLE_SPIN_BUTTON: 585 case ui::AX_ROLE_SPIN_BUTTON:
582 // This control is similar to what VoiceOver calls a "stepper". 586 // This control is similar to what VoiceOver calls a "stepper".
583 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 587 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
584 IDS_AX_ROLE_STEPPER)); 588 IDS_AX_ROLE_STEPPER));
585 case ui::AX_ROLE_TOGGLE_BUTTON: 589 case ui::AX_ROLE_TOGGLE_BUTTON:
586 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 590 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
587 IDS_AX_ROLE_TOGGLE_BUTTON)); 591 IDS_AX_ROLE_TOGGLE_BUTTON));
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 return [super hash]; 1450 return [super hash];
1447 return browserAccessibility_->GetId(); 1451 return browserAccessibility_->GetId();
1448 } 1452 }
1449 1453
1450 - (BOOL)accessibilityShouldUseUniqueId { 1454 - (BOOL)accessibilityShouldUseUniqueId {
1451 return YES; 1455 return YES;
1452 } 1456 }
1453 1457
1454 @end 1458 @end
1455 1459
OLDNEW
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698