Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 655263002: Let the paint-server client compute and pass any additional transform (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Let the paint-server client compute and pass any additional transform The clients/callers of updateGraphicsContext(...) already independently compute the same transform as computeResourceSpaceTransform(...). This means that we can get rid of the latter in favor of the computations in the callers - who just need to set up an AffineTransform and pass to updateGraphicsContext(...). This allows getting rid of the ApplyToTextMode resource-mode flag, and doing so allows converting the RenderSVGResourceMode enum to a non-bitmask such - and remove RenderSVGResourceModeFlags. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183776

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -63 lines) Patch
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 3 chunks +9 lines, -1 line 1 comment Download
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 3 chunks +5 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
Part deux for https://codereview.chromium.org/652243002/ https://codereview.chromium.org/655263002/diff/1/Source/core/paint/SVGInlineTextBoxPainter.cpp File Source/core/paint/SVGInlineTextBoxPainter.cpp (right): https://codereview.chromium.org/655263002/diff/1/Source/core/paint/SVGInlineTextBoxPainter.cpp#newcode276 Source/core/paint/SVGInlineTextBoxPainter.cpp:276: // FIXME: Non-scaling stroke is ...
6 years, 2 months ago (2014-10-15 15:42:11 UTC) #2
f(malita)
Nice, LGTM!
6 years, 2 months ago (2014-10-15 18:29:37 UTC) #3
pdr.
@fmalita, we owe this man so many beers. LGTM ___ ___ / /\ ___ /__/\ ...
6 years, 2 months ago (2014-10-16 00:27:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655263002/1
6 years, 2 months ago (2014-10-16 00:33:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:37:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183776

Powered by Google App Engine
This is Rietveld 408576698