Update the tests (ISO-8859-1 => windows-1252)

Update the tests (ISO-8859-1 => windows-1252)

To be compliant to the WHATWG Encoding spec (living standard), we should
treat ISO-8859-1 and windows-1252 synonymously. Moreover, windows-1252
is the canonical encoding name.

Update TextCodecLatin1 to list only aliases specified in the encoding
spec.

See https://codereview.chromium.org/598383002 (ICU update) and
    https://codereview.chromium.org/649413002 (roll ICU with necessary
    test/pref/UI changes in Chrome).

BUG=412053
TEST=fast/encoding/*
TEST=http/tests/misc/char*
R=jochen@chromium.org, jsbell@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183781

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183912

[jungshik at Google, 2014-10-15 00:05:09]

jshin@chromium.org changed reviewers:
+ jsbell@chromium.org, thakis@chromium.org

[jungshik at Google, 2014-10-15 00:05:09]

Can you take a look? I think this one can go in without a 3-way circus (Chrome,
Blink and ICU) :-)

[jungshik at Google, 2014-10-15 00:33:29]

jshin@chromium.org changed reviewers:
- thakis@chromium.org

[jungshik at Google, 2014-10-15 00:34:07]

jshin@chromium.org changed reviewers:
+ jochen@chromium.org

[jungshik at Google, 2014-10-15 00:34:07]

jochen@chromium.org: Please review/approve change in wtf/*. Thanks

[jsbell, 2014-10-15 00:51:13]

lgtm with nits

https://codereview.chromium.org/655083002/diff/40001/Source/wtf/text/TextCode...
File Source/wtf/text/TextCodecICU.cpp (right):

https://codereview.chromium.org/655083002/diff/40001/Source/wtf/text/TextCode...
Source/wtf/text/TextCodecICU.cpp:176: // and Firefox (24), but not in the
upstream ICU.
Should we indicate a version here? I guess a "date when this line changed" is
enough.

https://codereview.chromium.org/655083002/diff/40001/Source/wtf/text/TextCode...
Source/wtf/text/TextCodecICU.cpp:178: // TextCodecLatin1 register them.
typo: "register" -> "registers"

https://codereview.chromium.org/655083002/diff/40001/Source/wtf/text/TextCode...
Source/wtf/text/TextCodecICU.cpp:179: // TODO(jungshik): We may introduce
SYSTEM_ICU and enclose this block
Blink style is FIXME with no name.

[jochen (gone - plz use gerrit), 2014-10-15 15:24:32]

lgtm

[jungshik at Google, 2014-10-16 05:39:55]

Committed patchset #5 (id:80001) manually as 183781 (presubmit successful).

[cbiesinger, 2014-10-16 15:48:23]

On 2014/10/16 05:39:55, Jungshik Shin wrote:
> Committed patchset #5 (id:80001) manually as 183781 (presubmit successful).

This broke several browser_tests which depended on the previous behavior:
BrowserEncodingTest.TestOverrideEncoding
EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/16
BrowserEncodingTest.TestEncodingAutoDetect
EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/3

E.g.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Bro...

I reverted in https://codereview.chromium.org/658193002

[jungshik at Google, 2014-10-16 16:14:58]

On 2014/10/16 15:48:23, cbiesinger wrote:
> On 2014/10/16 05:39:55, Jungshik Shin wrote:
> > Committed patchset #5 (id:80001) manually as 183781 (presubmit successful).
> 
> This broke several browser_tests which depended on the previous behavior:
> BrowserEncodingTest.TestOverrideEncoding
> EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/16
> BrowserEncodingTest.TestEncodingAutoDetect
> EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/3
> 
> E.g.
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Bro...
> 
> I reverted in https://codereview.chromium.org/658193002

Sorry that I forgot to note that they're expected to fail. This CL and
https://codereview.chromium.org/649413002/ have to go hand in hand. 
I'll mark those tests as failing for now. Then, I'll reland this CL followed by
the Chromium CL (the above) that will also re-enable those tests.

[jungshik at Google, 2014-10-17 18:21:49]

Committed patchset #5 (id:80001) manually as 183912 (presubmit successful).

[jungshik at Google, 2014-10-17 18:34:07]

On 2014/10/17 18:21:49, Jungshik Shin wrote:
> Committed patchset #5 (id:80001) manually as 183912 (presubmit successful).

The local CL description edit was not reflected here (and in the commit-log):
Here's the update:

This is reverting the revert (I can't use the CL generated by 'revert of revert
CL' due to a riedvelt bug). This CL can now be landed safely because the failing
browser tests (Chromium) were temporarily disabled (or made robust against the
difference introduced by this Blink CL) in the following Cr CL (that got landed)
:
    
    https://codereview.chromium.org/643993004/