Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 658193002: Revert "Update the tests (ISO-8859-1 => windows-1252)" (Closed)

Created:
6 years, 2 months ago by cbiesinger
Modified:
6 years, 2 months ago
Reviewers:
jungshik at Google
CC:
blink-reviews, mkwst+moarreviews_chromium.org, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Project:
blink
Visibility:
Public.

Description

Revert "Update the tests (ISO-8859-1 => windows-1252)" This reverts commit 9c188b20fbb4d4c2006ab1a611ed8a9b971e7cee. Broke several browser_tests which depended on the previous behavior: BrowserEncodingTest.TestOverrideEncoding EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/16 BrowserEncodingTest.TestEncodingAutoDetect EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/3 E.g. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserEncodingTest.TestOverrideEncoding&testType=browser_tests TBR=jshin@chromium.org BUG=412053 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -35 lines) Patch
M LayoutTests/fast/encoding/bracket-in-tag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/charset-invalid.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/charset-invalid-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/encoding/charset-replacement.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/charset-replacement-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/encoding/misplaced-xml-declaration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/pseudo-xml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/encoding/meta-switch-mid-parse-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/char-encoding-in-hidden-charset-field-default.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/frame-default-enc-different-domain-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecICU.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/wtf/text/TextCodecLatin1.cpp View 1 chunk +28 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cbiesinger
Committed patchset #1 (id:1) manually as 183822 (presubmit successful).
6 years, 2 months ago (2014-10-16 15:47:43 UTC) #1
jungshik at Google
On 2014/10/16 15:47:43, cbiesinger wrote: > Committed patchset #1 (id:1) manually as 183822 (presubmit successful). ...
6 years, 2 months ago (2014-10-16 16:16:18 UTC) #2
cbiesinger
Jungshik, we haven't had a blink roll in the last 10 hours because these tests ...
6 years, 2 months ago (2014-10-16 16:27:12 UTC) #3
jungshik at Google
On 2014/10/16 16:27:12, cbiesinger wrote: > Jungshik, we haven't had a blink roll in the ...
6 years, 2 months ago (2014-10-16 17:32:46 UTC) #4
jungshik at Google
6 years, 2 months ago (2014-10-17 06:23:06 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/648163003/ by jshin@chromium.org.

The reason for reverting is: The failing browser tests (Chromium) were
temporarily disabled (or made robust against the difference introduced by this
Blink CL) in the following Cr CL (that got landed) :

https://codereview.chromium.org/643993004/

.

Powered by Google App Engine
This is Rietveld 408576698