Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: Source/core/testing/Internals.idl

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/testing/Internals.idl
diff --git a/Source/core/testing/Internals.idl b/Source/core/testing/Internals.idl
index 4b6ba69ca5672a0e8319fdb05986e705b9b6697d..d490df43024b7793fe78714c7ab5bd876c0b4920 100644
--- a/Source/core/testing/Internals.idl
+++ b/Source/core/testing/Internals.idl
@@ -279,7 +279,10 @@
// This function is for testing HitRegions on Canvas2D.
unsigned long countHitRegions(CanvasRenderingContext2D context);
+ [TypeChecking=Interface] ClientRect boundsInRootViewSpace(Element element);
esprehn 2014/10/21 20:50:48 What's with the TypeChecking attr? I don't think y
Zhen Wang 2014/10/21 21:36:48 ditto
sof 2014/10/22 05:22:46 Please keep using [TypeChecking=Inteface]. bounds
Zhen Wang 2014/10/22 13:55:55 I see. Thanks for pointing this out.
DOMString serializeNavigationMarkup();
+ DOMString[] getTransitionElementNames();
+ [RaisesException, TypeChecking=Interface] ClientRectList getTransitionElementRects();
esprehn 2014/10/21 20:50:48 Remove RaisesException, it doesn't use that argume
Zhen Wang 2014/10/21 21:36:48 I see other places using ClientRectList have Raise
void hideAllTransitionElements();
[RaisesException, TypeChecking=Interface] void forcePluginPlaceholder(HTMLElement plugin, DocumentFragment fragment);

Powered by Google App Engine
This is Rietveld 408576698