Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/web/FrameLoaderClientImpl.cpp

Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 107504056be14563f79a833c878ac0f713516dbe..0e1236b79ac1eb43b224afdf69436f629d0796ed 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -478,10 +478,15 @@ NavigationPolicy FrameLoaderClientImpl::decidePolicyForNavigation(const Resource
     return static_cast<NavigationPolicy>(webPolicy);
 }
 
-void FrameLoaderClientImpl::dispatchAddNavigationTransitionData(const String& allowedDestinationOrigin, const String& selector, const String& markup)
+void FrameLoaderClientImpl::dispatchAddNavigationTransitionData(
+    const String& allowedDestinationOrigin, const String& selector,
+    const String& markup, const Vector<String>& names,

[esprehn, 2014/10/21 20:50:49]

pass a struct instead of a long list of args.

[Zhen Wang, 2014/10/21 21:36:48]

Currently the implementation uses this interface. See:
https://codereview.chromium.org/652283002/diff/60001/content/renderer/render_...
(committed yesterday. not yet in online code search.)


Do you mean I should create something like WebTransitionElementData and pass the
data to content side?

+    const Vector<IntRect>& rects)
 {
-    if (m_webFrame->client())
-        m_webFrame->client()->addNavigationTransitionData(allowedDestinationOrigin, selector, markup);
+    if (m_webFrame->client()) {
+        m_webFrame->client()->addNavigationTransitionData(
+            allowedDestinationOrigin, selector, markup, names, rects);
+    }
 }
 
 void FrameLoaderClientImpl::dispatchWillRequestResource(FetchRequest* request)