Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use struct for transition element Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoaderClient.h
diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h
index 32f0be2b51de445dd6d3463289c68982d4e2f43e..42e4d4f349af513c5f643cb400de7a197d5bcb51 100644
--- a/Source/core/loader/FrameLoaderClient.h
+++ b/Source/core/loader/FrameLoaderClient.h
@@ -30,10 +30,12 @@
#ifndef FrameLoaderClient_h
#define FrameLoaderClient_h
+#include "core/dom/Document.h"
#include "core/dom/IconURL.h"
#include "core/frame/FrameClient.h"
#include "core/loader/FrameLoaderTypes.h"
#include "core/loader/NavigationPolicy.h"
+#include "platform/geometry/IntRect.h"
Nate Chapin 2014/11/05 18:29:43 Is this actually needed?
Zhen Wang 2014/11/06 17:59:26 Removed
#include "platform/heap/Handle.h"
#include "platform/network/ResourceLoadPriority.h"
#include "platform/weborigin/Referrer.h"
@@ -100,7 +102,7 @@ namespace blink {
virtual NavigationPolicy decidePolicyForNavigation(const ResourceRequest&, DocumentLoader*, NavigationPolicy, bool isTransitionNavigation) = 0;
- virtual void dispatchAddNavigationTransitionData(const String& origin, const String& selector, const String& markup) { }
+ virtual void dispatchAddNavigationTransitionData(const Document::TransitionElementData&) { }
Nate Chapin 2014/11/05 18:29:43 I'm not thrilled with this struct being part of Do
virtual void dispatchWillRequestResource(FetchRequest*) { }
virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) = 0;

Powered by Google App Engine
This is Rietveld 408576698