Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/core/loader/FrameLoaderClient.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 12 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef FrameLoaderClient_h
 #define FrameLoaderClient_h
 
+#include "core/dom/Document.h"
 #include "core/dom/IconURL.h"
 #include "core/frame/FrameClient.h"
 #include "core/loader/FrameLoaderTypes.h"
 #include "core/loader/NavigationPolicy.h"
+#include "platform/geometry/IntRect.h"

[Nate Chapin, 2014/11/05 18:29:43]

Is this actually needed?

[Zhen Wang, 2014/11/06 17:59:26]

Removed

 #include "platform/heap/Handle.h"
 #include "platform/network/ResourceLoadPriority.h"
 #include "platform/weborigin/Referrer.h"
 #include "wtf/Forward.h"
 #include "wtf/Vector.h"
 #include <v8.h>
 
 namespace blink {
 class WebCookieJar;
 class WebRTCPeerConnectionHandler;
@@ skipping 46 matching lines @@
         virtual void dispatchDidCommitLoad(LocalFrame*, HistoryItem*, HistoryCommitType) = 0;
         virtual void dispatchDidFailProvisionalLoad(const ResourceError&) = 0;
         virtual void dispatchDidFailLoad(const ResourceError&) = 0;
         virtual void dispatchDidFinishDocumentLoad() = 0;
         virtual void dispatchDidFinishLoad() = 0;
         virtual void dispatchDidFirstVisuallyNonEmptyLayout() = 0;
         virtual void dispatchDidChangeThemeColor() = 0;
 
         virtual NavigationPolicy decidePolicyForNavigation(const ResourceRequest&, DocumentLoader*, NavigationPolicy, bool isTransitionNavigation) = 0;
 
-        virtual void dispatchAddNavigationTransitionData(const String& origin, const String& selector, const String& markup) { }
+        virtual void dispatchAddNavigationTransitionData(const Document::TransitionElementData&) { }

[Nate Chapin, 2014/11/05 18:29:43]

I'm not thrilled with this struct being part of Document, but I don't have a
better idea.

         virtual void dispatchWillRequestResource(FetchRequest*) { }
 
         virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) = 0;
         virtual void dispatchWillSubmitForm(HTMLFormElement*) = 0;
 
         virtual void didStartLoading(LoadStartType) = 0;
         virtual void progressEstimateChanged(double progressEstimate) = 0;
         virtual void didStopLoading() = 0;
 
         virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& suggestedName = String()) = 0;
@@ skipping 106 matching lines @@
         virtual void didStopAllLoaders() { }
 
         virtual void dispatchDidChangeManifest() { }
 
         virtual bool isFrameLoaderClientImpl() const { return false; }
     };
 
 } // namespace blink
 
 #endif // FrameLoaderClient_h