Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: Source/core/dom/Document.h

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use struct for transition element Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index e83c97aa18cec21599a2312bfab6a87810ad673f..c75ba17bf207d8241384f1ba595366ec2ff9bb7c 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -385,10 +385,16 @@ public:
void setIsTransitionDocument() { m_isTransitionDocument = true; }
void hideTransitionElements(const AtomicString& cssSelector);
+ struct TransitionElement {
+ String name;
Nate Chapin 2014/11/05 18:29:43 Given that this is set based on the elment's id, s
Zhen Wang 2014/11/06 17:59:26 I see your point. I use "name" here because the
Nate Chapin 2014/11/11 00:28:17 Hrm. I guess consistency trumps having a sane name
Zhen Wang 2014/11/11 15:12:20 I see. Using "id" now.
+ IntRect rect;
+ };
+
struct TransitionElementData {
String scope;
String selector;
String markup;
+ Vector<TransitionElement> elements;
};
void getTransitionElementData(Vector<TransitionElementData>&);

Powered by Google App Engine
This is Rietveld 408576698