Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: Source/core/dom/Document.cpp

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use struct for transition element Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 69ac933bf334b8c45e8b1a1b1cc96dcf5aafa332..2ad8fd4107960e50ab9e5a633e853b7fc8e71369 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -60,6 +60,7 @@
#include "core/dom/AddConsoleMessageTask.h"
#include "core/dom/Attr.h"
#include "core/dom/CDATASection.h"
+#include "core/dom/ClientRect.h"
#include "core/dom/Comment.h"
#include "core/dom/ContextFeatures.h"
#include "core/dom/DOMImplementation.h"
@@ -5616,13 +5617,20 @@ void Document::getTransitionElementData(Vector<TransitionElementData>& elementDa
if (!nodeListLength)
continue;
+ TransitionElementData newElements;
StringBuilder markup;
for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) {
Element* element = elementList->item(nodeIndex);
markup.append(createStyledMarkupForNavigationTransition(element));
+ TransitionElement transitionElement;
+ if (element->hasID())
+ transitionElement.name = element->getIdAttribute().string();
+ else
+ transitionElement.name = "";
+ transitionElement.rect = element->boundsInRootViewSpace();
+ newElements.elements.append(transitionElement);
}
- TransitionElementData newElements;
newElements.scope = metaElementContents.substring(firstSemicolon + 1).stripWhiteSpace();
newElements.selector = selector;
newElements.markup = markup.toString();

Powered by Google App Engine
This is Rietveld 408576698