Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 654543008: Use remove_build_metadata.py on all the trybots. (Closed)

Created:
6 years, 1 month ago by Sébastien Marchand
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Use remove_build_metadata.py on all the trybots. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292727

Patch Set 1 : #

Messages

Total messages: 9 (4 generated)
Sébastien Marchand
Not sure that this is the best place to put this, but I'm not so ...
6 years, 1 month ago (2014-10-29 14:53:33 UTC) #4
M-A Ruel
Let's try it there, then roll out to chromium.py too. lgtm Note that this CL ...
6 years, 1 month ago (2014-10-29 18:09:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654543008/40001
6 years, 1 month ago (2014-10-29 18:41:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001) as 292727
6 years, 1 month ago (2014-10-29 18:42:50 UTC) #8
Sébastien Marchand
6 years, 1 month ago (2014-10-29 19:03:24 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/692623002/ by sebmarchand@chromium.org.

The reason for reverting is: The remove_build_metadata step shouldn't be a
failing step for now (it should just give a warning if zap_timestamp.exe fail
for some targets), I'll change that an I'll reland this one..

Powered by Google App Engine
This is Rietveld 408576698