Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 654543008: Use remove_build_metadata.py on all the trybots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/arm.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium_trybot.py
diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py
index 4028eb414e29675f6618587e7df9ac6a8ff3771b..c1d8598ffa6f60cc44d39d2df1517fe2045ee2f0 100644
--- a/scripts/slave/recipes/chromium_trybot.py
+++ b/scripts/slave/recipes/chromium_trybot.py
@@ -895,9 +895,13 @@ def GenSteps(api):
raise
raise
- # Collect *.isolated hashes for all isolated targets, used when triggering
- # tests on swarming.
if bot_config.get('use_isolate') or has_swarming_tests:
+ # Remove the build metadata from the binaries. Currently it's a noop on
+ # all platforms except Windows where it run zap_timestamp.exe on all the
+ # PE images.
+ api.isolate.remove_build_metadata()
+ # Collect *.isolated hashes for all isolated targets, used when triggering
+ # tests on swarming.
api.isolate.find_isolated_tests(api.chromium.output_dir)
if bot_config['compile_only']:
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/arm.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698