Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: scripts/slave/recipes/chromium_trybot.py

Issue 654543008: Use remove_build_metadata.py on all the trybots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/arm.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'bot_update', 6 'bot_update',
7 'chromium', 7 'chromium',
8 'chromium_tests', 8 'chromium_tests',
9 'gclient', 9 'gclient',
10 'isolate', 10 'isolate',
(...skipping 877 matching lines...) Expand 10 before | Expand all | Expand 10 after
888 888
889 # TODO(phajdan.jr): Set failed tryjob result after recognizing infra 889 # TODO(phajdan.jr): Set failed tryjob result after recognizing infra
890 # compile failures. We've seen cases of compile with patch failing 890 # compile failures. We've seen cases of compile with patch failing
891 # with build steps getting killed, compile without patch succeeding, 891 # with build steps getting killed, compile without patch succeeding,
892 # and compile with patch succeeding on another attempt with same patch. 892 # and compile with patch succeeding on another attempt with same patch.
893 except api.step.StepFailure: 893 except api.step.StepFailure:
894 api.tryserver.set_transient_failure_tryjob_result() 894 api.tryserver.set_transient_failure_tryjob_result()
895 raise 895 raise
896 raise 896 raise
897 897
898 # Collect *.isolated hashes for all isolated targets, used when triggering
899 # tests on swarming.
900 if bot_config.get('use_isolate') or has_swarming_tests: 898 if bot_config.get('use_isolate') or has_swarming_tests:
899 # Remove the build metadata from the binaries. Currently it's a noop on
900 # all platforms except Windows where it run zap_timestamp.exe on all the
901 # PE images.
902 api.isolate.remove_build_metadata()
903 # Collect *.isolated hashes for all isolated targets, used when triggering
904 # tests on swarming.
901 api.isolate.find_isolated_tests(api.chromium.output_dir) 905 api.isolate.find_isolated_tests(api.chromium.output_dir)
902 906
903 if bot_config['compile_only']: 907 if bot_config['compile_only']:
904 tests = [] 908 tests = []
905 909
906 return tests, bot_update_step 910 return tests, bot_update_step
907 911
908 mastername = api.properties.get('mastername') 912 mastername = api.properties.get('mastername')
909 buildername = api.properties.get('buildername') 913 buildername = api.properties.get('buildername')
910 bot_config = get_bot_config(mastername, buildername) 914 bot_config = get_bot_config(mastername, buildername)
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
1590 'test': 'base_tests', 1594 'test': 'base_tests',
1591 'args': ['--gtest-filter: *NaCl*.*'], 1595 'args': ['--gtest-filter: *NaCl*.*'],
1592 }, 1596 },
1593 ], 1597 ],
1594 }) 1598 })
1595 ) + 1599 ) +
1596 api.override_step_data( 1600 api.override_step_data(
1597 'analyze', 1601 'analyze',
1598 api.json.output({'invalid_targets': 'invalid target'})) 1602 api.json.output({'invalid_targets': 'invalid target'}))
1599 ) 1603 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/arm.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698