Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/gn/scope.h

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/scope.h
diff --git a/tools/gn/scope.h b/tools/gn/scope.h
index 035d45b6a26360764610851b93a5b636172a01a2..4494458e227a478ba72022e046d8e25950328243 100644
--- a/tools/gn/scope.h
+++ b/tools/gn/scope.h
@@ -40,9 +40,8 @@ class Template;
class Scope {
public:
typedef base::hash_map<base::StringPiece, Value> KeyValueMap;
- // Holds an owning list of scoped_ptrs of Items (since we can't make a vector
- // of scoped_ptrs).
- typedef ScopedVector< scoped_ptr<Item> > ItemVector;
+ // Holds an owning list of Items.
+ typedef ScopedVector<Item> ItemVector;
// Allows code to provide values for built-in variables. This class will
// automatically register itself on construction and deregister itself on
« tools/gn/loader.cc ('K') | « tools/gn/loader.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698