Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/gn/functions.cc

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/functions.cc
diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc
index c68eda53adcae947ee252754d8c5c4a2b416e917..0d60d688adc47980b20123e58cc6d8d85656e20d 100644
--- a/tools/gn/functions.cc
+++ b/tools/gn/functions.cc
@@ -251,7 +251,7 @@ Value RunConfig(const FunctionCallNode* function,
*err = Err(function, "Can't define a config in this context.");
return Value();
}
- collector->push_back(new scoped_ptr<Item>(config.PassAs<Item>()));
+ collector->push_back(config.release());
return Value();
}
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/loader.cc » ('j') | tools/gn/loader.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698