Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/gn/function_get_target_outputs.cc

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/function_get_target_outputs_unittest.cc » ('j') | tools/gn/loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_get_target_outputs.cc
diff --git a/tools/gn/function_get_target_outputs.cc b/tools/gn/function_get_target_outputs.cc
index 163b187d82049940c772f5b7db868d91c656ca42..dd2de0c733cbbb196989ede747c820dab89ce93e 100644
--- a/tools/gn/function_get_target_outputs.cc
+++ b/tools/gn/function_get_target_outputs.cc
@@ -92,8 +92,7 @@ Value RunGetTargetOutputs(Scope* scope,
*err = Err(function, "No targets defined in this context.");
return Value();
}
- for (const auto& cur : *collector) {
- const Item* item = cur->get();
+ for (const auto& item : *collector) {
if (item->label() != label)
continue;
« no previous file with comments | « no previous file | tools/gn/function_get_target_outputs_unittest.cc » ('j') | tools/gn/loader.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698