Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2268)

Unified Diff: chrome/test/chromedriver/net/net_util.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.h ('k') | chrome/test/chromedriver/net/net_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/net/net_util.cc
diff --git a/chrome/test/chromedriver/net/net_util.cc b/chrome/test/chromedriver/net/net_util.cc
index 518c2369f20b5c69bc6d192d380d46bbc44ab5ff..401b20dc2494724cff7a9ee204ce95f3fa3e1940 100644
--- a/chrome/test/chromedriver/net/net_util.cc
+++ b/chrome/test/chromedriver/net/net_util.cc
@@ -26,7 +26,7 @@ class SyncUrlFetcher : public net::URLFetcherDelegate {
std::string* response)
: url_(url), getter_(getter), response_(response), event_(false, false) {}
- virtual ~SyncUrlFetcher() {}
+ ~SyncUrlFetcher() override {}
bool Fetch() {
getter_->GetNetworkTaskRunner()->PostTask(
@@ -42,7 +42,7 @@ class SyncUrlFetcher : public net::URLFetcherDelegate {
fetcher_->Start();
}
- virtual void OnURLFetchComplete(const net::URLFetcher* source) override {
+ void OnURLFetchComplete(const net::URLFetcher* source) override {
success_ = (source->GetResponseCode() == 200);
if (success_)
success_ = source->GetResponseAsString(response_);
« no previous file with comments | « chrome/test/chromedriver/logging.h ('k') | chrome/test/chromedriver/net/net_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698