Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 653563003: cc: Plumb group id through animation creation and start/finish notifications (Closed)

Created:
6 years, 2 months ago by dstockwell
Modified:
6 years, 2 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, blink-reviews-animation_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Plumb group id through animation creation and start/finish notifications This is required for Blink to track the synchronized starting of groups of animations. Blink side plumbing: https://codereview.chromium.org/652593003 Blink usage: https://codereview.chromium.org/651103002 BUG=423265 Committed: https://crrev.com/af2a117bc134fda5a292754e7be5d0072ec6a891 Cr-Commit-Position: refs/heads/master@{#299979}

Patch Set 1 #

Patch Set 2 : Pass groupId to createAnimation #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -46 lines) Patch
M cc/animation/animation_delegate.h View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/blink/web_animation_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_animation_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/blink/web_compositor_support_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/blink/web_compositor_support_impl.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M cc/blink/web_to_cc_animation_delegate_adapter.h View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/blink/web_to_cc_animation_delegate_adapter.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 8 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dstockwell
6 years, 2 months ago (2014-10-16 06:30:10 UTC) #2
dstockwell
6 years, 2 months ago (2014-10-16 06:32:06 UTC) #3
ajuma
lgtm
6 years, 2 months ago (2014-10-16 13:25:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653563003/220001
6 years, 2 months ago (2014-10-16 21:20:21 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:220001)
6 years, 2 months ago (2014-10-16 21:42:46 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:44:11 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/af2a117bc134fda5a292754e7be5d0072ec6a891
Cr-Commit-Position: refs/heads/master@{#299979}

Powered by Google App Engine
This is Rietveld 408576698