Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 651103002: Web Animations: Compositor start notification should only apply to animations in a matching group (Closed)

Created:
6 years, 2 months ago by dstockwell
Modified:
5 years, 11 months ago
Reviewers:
shans
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr+renderingwatchlist_chromium.org, rjwright, rune+blink, shans, Steve Block, Timothy Loh, zoltan1
Project:
blink
Visibility:
Public.

Description

Web Animations: Compositor start notification should only apply to animations in a matching group Addresses a race condition where a start notification could be applied to animations not yet serviced by the compositor. Batches of animations sent to the compositor are now identified by group ids. TESTED=ManualTests/animation BUG=423265 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186657

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -43 lines) Patch
M Source/core/animation/Animation.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 2 3 1 chunk +2 lines, -7 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 3 4 chunks +9 lines, -4 lines 0 comments Download
M Source/core/animation/CompositorAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorPendingAnimations.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.cpp View 1 2 3 2 chunks +21 lines, -18 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dstockwell
6 years ago (2014-12-08 00:59:38 UTC) #2
shans
lgtm
6 years ago (2014-12-08 03:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651103002/60001
6 years ago (2014-12-08 03:47:13 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=186657
6 years ago (2014-12-08 04:07:52 UTC) #6
loyso (OOO)
5 years, 11 months ago (2015-01-13 03:03:27 UTC) #7
Message was sent while issue was closed. 
On 2014/12/08 04:07:52, I haz the power (commit-bot) wrote:
> Committed patchset #4 (id:60001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=186657

This CL introduces bugs like this:
https://code.google.com/p/chromium/issues/detail?id=431580

Powered by Google App Engine
This is Rietveld 408576698