Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 652593003: Web Animations: Plumb compositor group id through animation creation and start/finish notifications (Closed)

Created:
6 years, 2 months ago by dstockwell
Modified:
6 years, 2 months ago
CC:
darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, Rik, danakj, dglazkov+blink, krit, dstockwell, eae+blinkwatch, Eric Willigers, jbroman, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), mkwst+moarreviews_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, rune+blink, Stephen Chennney, shans, Steve Block, Timothy Loh, zoltan1
Project:
blink
Visibility:
Public.

Description

Web Animations: Plumb compositor group id through animation creation and start/finish notifications This is required for Blink to track the synchronized starting of groups of animations. Depends on a change in chromium: https://codereview.chromium.org/653563003 Follow on usage: https://codereview.chromium.org/651103002 BUG=423265 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183950

Patch Set 1 #

Patch Set 2 : Pass groupId to createAnimation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -39 lines) Patch
M Source/core/animation/CompositorAnimationsTest.cpp View 1 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/frame/PinchViewport.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/PinchViewport.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/LinkHighlight.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/PageOverlay.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebCompositorAnimation.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebCompositorAnimationDelegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M public/platform/WebCompositorSupport.h View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dstockwell
6 years, 2 months ago (2014-10-16 06:35:58 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-17 11:54:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652593003/180001
6 years, 2 months ago (2014-10-19 22:07:50 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-19 23:14:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:180001) as 183950

Powered by Google App Engine
This is Rietveld 408576698