Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1956)

Issue 653013002: Revert of Making scheduler run ANIMATE after a COMMIT (instead of LayerTreeHostImpl). (Closed)

Created:
6 years, 2 months ago by loislo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Making scheduler run ANIMATE after a COMMIT (instead of LayerTreeHostImpl). (patchset #4 id:50001 of https://codereview.chromium.org/621823003/) Reason for revert: Some sites become "unresponsive" i.e. they work but have no ui changes. and the user need to switch between tabs in order of getting the actual page. Original issue's description: > Making scheduler run ANIMATE after a COMMIT (instead of LayerTreeHostImpl). > > This moves the logic from the LayerTreeHostImpl into the scheduler which means > only ScheduledActionAnimate now updates animation state. > > The further extends the work in http://crrev.com/206793003 > > BUG=346230 > > Committed: https://crrev.com/7fa5729cf6ac490cc3b257b7eb8093dcd1285e3a > Cr-Commit-Position: refs/heads/master@{#298396} TBR=ajuma@chromium.org,skyostil@google.com,brianderson@chromium.org,danakj@chromium.org,skyostil@chromium.org,mithro@mithis.com NOTREECHECKS=true NOTRY=true BUG=346230 Committed: https://crrev.com/94262ca64cfa008ee006e85e3e0cdfbcc1c1e3cb Cr-Commit-Position: refs/heads/master@{#299441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -56 lines) Patch
M cc/scheduler/scheduler_state_machine.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 7 chunks +1 line, -17 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/thread_proxy.cc View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
Created Revert of Making scheduler run ANIMATE after a COMMIT (instead of LayerTreeHostImpl).
6 years, 2 months ago (2014-10-14 07:06:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653013002/1
6 years, 2 months ago (2014-10-14 07:06:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 07:07:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/94262ca64cfa008ee006e85e3e0cdfbcc1c1e3cb Cr-Commit-Position: refs/heads/master@{#299441}
6 years, 2 months ago (2014-10-14 07:08:12 UTC) #4
loislo
6 years, 2 months ago (2014-10-14 07:08:34 UTC) #5
Message was sent while issue was closed.
On 2014/10/14 07:06:24, loislo wrote:
> Created Revert of Making scheduler run ANIMATE after a COMMIT (instead of
> LayerTreeHostImpl).

crbug.com/420254

Powered by Google App Engine
This is Rietveld 408576698