Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 652673002: NOT FOR REVIEW: Modify ToggleFullscreenMode. (Closed)

Created:
6 years, 2 months ago by Ignacio Solla
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, jam, nasko+codewatch_chromium.org, avayvod+watch_chromium.org, penghuang+watch_chromium.org, mkwst+moarreviews-ipc_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su, android-webview-reviews_chromium.org, yukishiino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fixPowerBlockerNonMedia
Project:
chromium
Visibility:
Public.

Description

NOT FOR REVIEW: Modify ToggleFullscreenMode. This change still needs further work. The purpose is to show an alternative implementation for: https://codereview.chromium.org/618013003/ If this alternative is prefered, I will cherry pick this commit into patch 618013003. BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -120 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 2 chunks +8 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 2 chunks +16 lines, -5 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +18 lines, -7 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +3 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 2 chunks +7 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 chunk +0 lines, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -20 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698