components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 652673002: NOT FOR REVIEW: Modify ToggleFullscreenMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 652673002: NOT FOR REVIEW: Modify ToggleFullscreenMode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixPowerBlockerNonMedia

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index c85896bde4c56550b17eea059006c661bf63eaf2..bcb86924342e950e21f6ad4ef3413c881b0a313b 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -328,13 +328,13 @@ void WebContentsDelegateAndroid::ShowRepostFormWarningDialog(

void WebContentsDelegateAndroid::ToggleFullscreenModeForTab(

WebContents* web_contents,

- bool enter_fullscreen) {

+ bool enter_fullscreen, bool is_video) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);

if (obj.is_null())

return;

Java_WebContentsDelegateAndroid_toggleFullscreenModeForTab(

- env, obj.obj(), enter_fullscreen);

+ env, obj.obj(), enter_fullscreen, is_video);

}

bool WebContentsDelegateAndroid::IsFullscreenForTabOrPending(